Add parser and downloader factory for the upgrade case #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were inconsistently handling temp dirs: - In some places, errors were ignored when removing temp dirs - One temp dir was never actually used - There was a mishmash of styles - It was overly verbose
# Conflicts: # templates/common/templatesource/remote_git.go
# Conflicts: # templates/commands/goldentest/record.go # templates/commands/goldentest/verify.go
# Conflicts: # templates/commands/describe/describe.go
drevell
changed the title
capri-xiyue
reviewed
Feb 14, 2024
yolocs
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're doing template upgrades, we'll have a canonical location and a location type, and we'll need a
Downloaderto get the new template contents. This code does just that:f(location_type, location) -> Downloader