Feature/dsc 93 event stream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschristensen
force-pushed
the
feature/DSC-93-event-stream
branch
from
fc940a4
to
3303b04
Compare
This initial Stream implementation adds a very simple wrapper around an Ably channel. Messages received on the channel are surfaced to the caller via a subscription callback. The Stream is an EventEmitter and exposes its state via events. Additionally the stream can be pauses, resumed and disposed. This will allow the Models SDK to manipulate the stream/channel according to the model's lifecycle. While not yet particularly useful, the idea is that the Stream will handle: - message de-duplication - message re-ordering - detect discontinuities (due to connection state recovery as well as due to failed connector publishes)
mschristensen
force-pushed
the
feature/DSC-93-event-stream
branch
from
3303b04
to
4b97a65
Compare
andydunstall
approved these changes
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a very simple
Streamimplementation which will later be extended to support message de-duplication, re-ordering, discontinuity detection and more.Uses
vitestto mock the Ably Realtime client in unit tests.