Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the work done to shard workflows in order to work around GitHub's lack of capability to re-run specific jobs, rather than entire workflows #1311

Closed
QuintinWillison opened this issue Mar 17, 2022 · 0 comments · Fixed by #1840
Closed

Revert the work done to shard workflows in order to work around GitHub's lack of capability to re-run specific jobs, rather than entire workflows #1311

QuintinWillison opened this issue Mar 17, 2022 · 0 comments · Fixed by #1840
Assignees
@maratal

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Mar 17, 2022 •
edited by sync-by-unito bot
Loading

owenpearson spotted a new blog post from GitHub: Save time with partial re-runs in GitHub Actions.

If that ☝️ solves the issue for us in terms of re-runs, then we should undo the work done under #1274 in order to get rid of the current repetition we have between workflow files.

┆Issue is synchronized with this Jira Task by Unito
@maratal maratal mentioned this issue Nov 19, 2023
Merged
lawrence-forooghian added a commit that referenced this issue Dec 14, 2023
@lawrence-forooghian
Add a link to the GitHub job in observability server upload
c44cea5 
Currently, the observability server UI links to the workflow run attempt
that the upload corresponds to. This is fine in the case where the
workflow only contains a single job, as it currently does in ably-cocoa.
But in the case where there’s more than one job in a workflow (e.g. in
the case of a matrix build, which we intend to switch ably-cocoa to
using in #1311), there’s no way to tell which job an upload corresponds
to. So, include this information in the upload.

Copied from test-observability-action commit d4d651c.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 14, 2023
Merged
lawrence-forooghian added a commit that referenced this issue Dec 14, 2023
@lawrence-forooghian
Add a link to the GitHub job in observability server upload
d7e7736 
Currently, the observability server UI links to the workflow run attempt
that the upload corresponds to. This is fine in the case where the
workflow only contains a single job, as it currently does in ably-cocoa.
But in the case where there’s more than one job in a workflow (e.g. in
the case of a matrix build, which we intend to switch ably-cocoa to
using in #1311), there’s no way to tell which job an upload corresponds
to. So, include this information in the upload.

Copied from test-observability-action commit d4d651c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maratal maratal

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SDK-1683] Single workflow with matrix strategy ably/ably-cocoa
2 participants
@QuintinWillison @maratal