Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 40012 "Malformed message; invalid clientId" when message has no clientId and credentials can assume any clientId #1082

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Fixes 40012 "Malformed message; invalid clientId" when message has no clientId and credentials can assume any clientId #1082

merged 6 commits into from
Nov 4, 2020

Conversation

ricardopereira
Copy link
Contributor

@ricardopereira ricardopereira self-assigned this Oct 23, 2020
@ricardopereira
Copy link
Contributor Author

Screenshot 2020-10-23 at 09 26 56

QuintinWillison
QuintinWillison suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not looked in detail at the tests as I'm short for time, but I've made some comment on the implementation.

Source/ARTHttp.m Outdated Show resolved Hide resolved
Source/ARTRestChannel.m Show resolved Hide resolved
tiholic
tiholic approved these changes Nov 2, 2020
View reviewed changes
Copy link

@tiholic tiholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source/ARTRestChannel.m looks good to me.
Haven't looked at other changes.

@QuintinWillison QuintinWillison merged commit beefc50 into main Nov 4, 2020
@QuintinWillison QuintinWillison deleted the fix-1074 branch November 4, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintinWillison QuintinWillison QuintinWillison approved these changes

@tiholic tiholic tiholic approved these changes

Assignees

@ricardopereira ricardopereira

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardopereira @QuintinWillison @tiholic