Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1268 push error field #1269

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix/1268 push error field #1269

wants to merge 3 commits into from

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Jan 20, 2022

No description provided.

@maratal maratal linked an issue Jan 20, 2022 that may be closed by this pull request
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps before we start trying to parse this field, we should get it added to the documentation for the "get details from a registered device" etc REST API endpoints?

@lukasz-szyszkowski
Copy link
Contributor

Perhaps before we start trying to parse this field, we should get it added to the documentation for the "get details from a registered device" etc REST API endpoints?

Isn't described in Common API behavior -> General? Just below the text All other standard HTTP statusCodes signify an error. Errors from all APIs are returned as an object of the form:

{
  error: {
    code: <ably error code>,
    message: <string>,
    statusCode: <http status code>
  }
}

🤔

@lawrence-forooghian
Copy link
Collaborator

No, I think that’s describing what the response looks like if there’s an error in responding to the HTTP request. The error we’re talking about here is nested inside an object that represents a device, and I believe may be present even if the response has a 200 status.

@lukasz-szyszkowski
Copy link
Contributor

No, I think that’s describing what the response looks like if there’s an error in responding to the HTTP request. The error we’re talking about here is nested inside an object that represents a device, and I believe may be present even if the response has a 200 status.

agree 👍

@lawrence-forooghian
Copy link
Collaborator

@maratal looks like this isn't ready for review and there's been no activity on it for a while, so I've converted it to a draft.

@maratal
Copy link
Collaborator Author

maratal commented Oct 28, 2022

Blocked by docs ably/specification#23 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Invalid error field name in JSON parser
3 participants