Remove shared AblyTests.queue
#1707
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
identify-test
branch
from
11e469d
to
4915315
Compare
Just a refactor. TODO I should be splitting this up into a commit per method, to make it clearer
we're assuming that they want these to be the same thing, not obvious why TODO change this so that everything takes an explicit queue parameter, and then go through and find all of the tests where AblyTests.queue is referred to multiple times and turn them into a variable
Motivation as in cd80ddb.
This serves as a handy way of knowing when the corresponding dispatch queue is being created and destroyed, and hence finding out whether we’re leaking dispatch queues.
There are loads — why?
lawrence-forooghian
force-pushed
the
remove-shared-AblyTests.queue
branch
from
0d7667f
to
154911e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.