-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message interactions #1785
Draft
AndyTWF
wants to merge
8
commits into
main
Choose a base branch
from
message-interactions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Message interactions #1785
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for daad7b5 - Browse repository at this point
Copy the full SHA daad7b5View commit details -
Similar to the ably-java implementation of the same class, checks the message extras and a few other fields on the message to check that they match the user-provided filter. This class will be used as part of a message filterer to implement filtered message interactions.
Configuration menu - View commit details
-
Copy full SHA for 740b54b - Browse repository at this point
Copy the full SHA 740b54bView commit details
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b69693d - Browse repository at this point
Copy the full SHA b69693dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09c4eaa - Browse repository at this point
Copy the full SHA 09c4eaaView commit details -
Implement manager class for filtered listeners
Rather than manage filtered listeners directly in the channel class, which makes it awkward to test in isolation, the ARTFilteredListeners class separates out this behaviour. Also adds a filtered listener class that applies the filter before calling the listener.
Configuration menu - View commit details
-
Copy full SHA for 9a4ef98 - Browse repository at this point
Copy the full SHA 9a4ef98View commit details -
[RTL22] Message interaction subscriptions
This change implements the message interactions specification RTL22 for the ARTRealtimeChannel class. Includes a method to subscribe a listener with a filter as well as one to remove listeners based on the filter they have associated with them (if at all).
Configuration menu - View commit details
-
Copy full SHA for f2f9f76 - Browse repository at this point
Copy the full SHA f2f9f76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c27e29 - Browse repository at this point
Copy the full SHA 2c27e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ae1d5 - Browse repository at this point
Copy the full SHA a4ae1d5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.