Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QueueMessages when set to false #1216

Merged
merged 14 commits into from
May 22, 2023
Merged

Fix QueueMessages when set to false #1216

merged 14 commits into from
May 22, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Mar 21, 2023 •
edited
Loading

Fixed queueing that happens for following states
CONNECTIONCLOSING, CONNECTIONCLOSED, CONNECTIONSUSPENDED, CONNECTIONFAILED
when QueueMessages=false

@github-actions github-actions bot temporarily deployed to staging/pull/1216/features March 21, 2023 15:14 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features March 22, 2023 12:51 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 1, 2023 •
edited
Loading

More tests need to be added for missing cases.

@github-actions github-actions bot temporarily deployed to staging/pull/1216/features April 26, 2023 18:23 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features April 27, 2023 06:01 Inactive
@sacOO7 sacOO7 force-pushed the bugfix/clientoptions-queuemessages branch from 6a85651 to 53fd107 Compare April 27, 2023 06:04
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features April 27, 2023 06:04 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features April 28, 2023 17:44 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 30, 2023

It seems test can be updated for send using TestTransportFactory

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 30, 2023

Need to mock send response, failing the message and then checking the failed message doesn't get added to the queue.

@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 11, 2023 17:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 14, 2023 17:31 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 14, 2023 17:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 14, 2023 18:23 Inactive
@sacOO7 sacOO7 requested a review from marto83 May 14, 2023 18:28
@sacOO7 sacOO7 marked this pull request as ready for review May 14, 2023 18:28
SimonWoolf
SimonWoolf reviewed May 15, 2023
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments, overall looks plausible to me but I'll leave it to Owen to approve when he's happy

src/IO.Ably.Shared/Transport/ConnectionManager.cs Outdated Show resolved Hide resolved
src/IO.Ably.Shared/Transport/ConnectionManager.cs Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 18, 2023 15:55 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1216/features May 22, 2023 08:45 Inactive
owenpearson
owenpearson approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

owenpearson
owenpearson approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@sacOO7
Copy link
Collaborator Author

sacOO7 commented May 22, 2023

Thanks for the approval, merging the PR : )

@sacOO7 sacOO7 merged commit f387e1d into main May 22, 2023
@sacOO7 sacOO7 deleted the bugfix/clientoptions-queuemessages branch May 22, 2023 10:26
@sacOO7 sacOO7 mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@marto83 marto83 Awaiting requested review from marto83

@SimonWoolf SimonWoolf Awaiting requested review from SimonWoolf

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix QueueMessages ClientOption
3 participants
@sacOO7 @SimonWoolf @owenpearson