[ECO-4650] fix: remove message grouping for Ably Batch calls #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
b8b7336
to
b59bb2b
Compare
|
@ttypic I assume you meant to tag me & andy as reviewers on this, not assign it to us? |
|
@SimonWoolf , oh, I am sorry 🙈 miss clicked |
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
b59bb2b
to
732b03a
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
732b03a
to
ede5923
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
ede5923
to
834e9ec
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
b81b202
to
bd964d9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
bd964d9
to
80ea287
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
ttypic
changed the title
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
80ea287
to
7c45690
Compare
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably
github-actions
bot
temporarily deployed
to
staging/pull/180/kafka-connect-ably-msk-plugin
AndyTWF
approved these changes
Mar 13, 2024
src/main/java/com/ably/kafka/connect/client/DefaultAblyBatchClient.java
Outdated
Show resolved
Hide resolved
SimonWoolf
reviewed
Mar 13, 2024
The kafka connector put every message sent to a single channel in one `BatchSpec`, meaning we treated them atomically and send them as a single `ProtocolMessage`. This causes a problem when the total `ProtocolMessage` size gets way too big. That's why now we put every message in its own `BatchSpec`
ttypic
force-pushed
the
ECO-4650/remove-message-grouping-for-batch
branch
from
7c45690
to
7e4dc40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #171
Jira issue ECO-4650
The kafka connector put every message sent to a single channel in one
BatchSpec, meaning we treated them atomically and send them as a singleProtocolMessage.This causes a problem when the total
ProtocolMessagesize gets way too big.That's why now we put every message in its own
BatchSpec