Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define behaviour of RestClient#request when user specifies an X-Ably-Version header #144

Open
lawrence-forooghian opened this issue May 1, 2023 · 1 comment

Comments

@lawrence-forooghian
Copy link
Collaborator

What wins in this case — that specified by RSC7a or that specified by the user?

@sync-by-unito
Copy link

sync-by-unito bot commented May 1, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3564

lawrence-forooghian added a commit that referenced this issue May 1, 2023
There’s still a question of how this method is meant to behave if the user also
specifies an `X-Ably-Header` header in the `headers` parameter. But it’s a
question that equally applied before adding the `version` parameter, so I’ve
captured it in a separate issue #144.

Same comment as 69e1973 re needing to update "replaced in" spec version before
merging integration branch into `main` applies here too.
lawrence-forooghian added a commit that referenced this issue May 1, 2023
There’s still a question of how this method is meant to behave if the user also
specifies an `X-Ably-Header` header in the `headers` parameter. But it’s a
question that equally applied before adding the `version` parameter, so I’ve
captured it in a separate issue #144.

Same comment as 69e1973 re needing to update "replaced in" spec version before
merging integration branch into `main` applies here too.
lawrence-forooghian added a commit that referenced this issue May 2, 2023
There’s still a question of how this method is meant to behave if the user also
specifies an `X-Ably-Header` header in the `headers` parameter. But it’s a
question that equally applied before adding the `version` parameter, so I’ve
captured it in a separate issue #144.

Same comment as 69e1973 re needing to update "replaced in" spec version before
merging integration branch into `main` applies here too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant