Add exception to resent-messages-on-new-transport if queueMessages=false #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And trivial reword to some related spec items
|
@owenpearson d'you want this in main or integration/3? |
|
@SimonWoolf I reckon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And trivial reword to some related spec items
Implements #134
I struggled a bit with how this is split across RTN7 (ack/nack) and RTN19a (transport state change side effects), it's messy. Considered merging everything into RTN7 and getting rid of RTN19a, but gave up - ultimately added it as RTN7d because it was most similar to RTN7c (and it's a connection state change side effect not a transport one), but made sure the two both mention each other.