RSA7f: clarify that send clientId regardless of basic/token auth #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sacOO7
reviewed
Jul 5, 2024
|
I originally had this as adding a new RSA7f and deprecating RSA7e for <=3.0.0. But I've changed my mind, now just editing RSA7e in-place. Having RSA7e claim to be valid for <=3.0.0 ignores the reality that no SDK actually implemented RSA7e as written, so may as well change it to just reflect what they actually do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous RSA7e said to only send clientId in the querystring & x-ably-clientid header in rest reqs if using basic auth. Which is just wrong, and not what any sdk does. (ably-js sends it unconditionally, ably-ruby sends it if token auth is used and it can see that the token has a wildcard client -- which is still wrong because the sdk might not know what the token clientId is if it's fed an opaque token string).
internal discussion: https://ably-real-time.slack.com/archives/C8SPU4589/p1720167508719079
(could argue this is a semver breaking change... but given no SDK actually implemented the previous spec as written, in practice it isn't)