This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Support stacked borrows in BufWriter::into_inner_ #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
support-stacked-borrows
branch
from
7a2cbe8
to
b89a914
Compare
This avoids errors in miri due to mem::forget currently behaving like a regular function call with the current stacked borrows model.
KamilaBorowska
force-pushed
the
support-stacked-borrows
branch
from
b89a914
to
e6370a9
Compare
|
Looks good to me! I don't remember what minimum Rust version I intended to support but 1.20 is probably old enough (and I'm probably accidentally requiring something newer anyway). Does this need an immediate publish like the |
|
Published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids errors in miri due to mem::forget currently behaving like a regular function call.
Also see rust-lang/rust#62610.