Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch07 addendum: reduce compile size Hub #37

Conversation

benjaminbollen
Copy link
Member

problem: patch 7 consumes more compiled size than Hub.sol has available

  • rolled back the gas optimisations of patch 7 on the non-frequented path (ie. stop, stopped, registerHuman etc where the difference was already small), but kept the gas optimisations on the frequented paths of ERC1155 transfers, and demurrage calculations (esp in path transfers)
  • to make up for the additional compile size needed, moved the helper functions in Hub for inflationary balanceOf and safe(Batch)Transfer out of hub and into a helper operator contract that people must authorize in order to have it help convert inflationary amounts to demurrage amounts and then execute the transferFrom

@benjaminbollen benjaminbollen changed the base branch from develop to 20240807-patch07-remove-redundant-SSTORE-SLOAD August 8, 2024 15:48
@benjaminbollen benjaminbollen changed the base branch from 20240807-patch07-remove-redundant-SSTORE-SLOAD to rc-v0.3.5 August 8, 2024 15:49
@benjaminbollen benjaminbollen changed the base branch from rc-v0.3.5 to rc-v0.3.5-patch1to8 August 8, 2024 15:50
@benjaminbollen benjaminbollen mentioned this pull request Aug 8, 2024
37 tasks
@benjaminbollen
Copy link
Member Author

included in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant