Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PR template #617

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

dotarjun
Copy link
Contributor

fixes #616

Signed-off-by: dotarjun <arjunsingh8112@gmail.com>

feat: add PR template

Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
@OmkarPh
Copy link
Collaborator

OmkarPh commented Dec 1, 2023

I'm not sure if we want an elaborated or minimal PR template like scancode-toolkit here
CC @AyanSinhaMahapatra

Copy link
Collaborator

@OmkarPh OmkarPh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dotarjun
As discussed in the community call, we want a small and simple PR template like scancode-toolkit I mentioned above

You can use the following text for testing point:
Tests pass -- Run npm test locally to check for errors. Look for a green checkbox ✔️ a few minutes after opening your PR

@OmkarPh
Copy link
Collaborator

OmkarPh commented Dec 25, 2023

gentle ping @dotarjun

Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Signed-off-by: dotarjun <arjunsingh8112@gmail.com>
@OmkarPh
Copy link
Collaborator

OmkarPh commented Feb 20, 2024

LGTM, merging

@OmkarPh OmkarPh merged commit 4ed7892 into aboutcode-org:develop Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR template
2 participants