Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan_package should not fail if there is an error in the scan #1018

Closed
pombredanne opened this issue Dec 1, 2023 · 1 comment
Closed

scan_package should not fail if there is an error in the scan #1018

pombredanne opened this issue Dec 1, 2023 · 1 comment

Comments

@pombredanne
Copy link
Contributor

When scanning https://codeload.github.com/ElinamLLC/SharpVectors/tar.gz/refs/tags/v1.8.2 with "scan_package" the pipeline fails with:

{'codebase/SharpVectors-1.8.2/Source/SharpVectorModel/Compressions/Brotli/Dictionary.cs': ['ERROR: for scanner: copyrights:\nERROR: Processing interrupted: timeout after 120 seconds.']}

Traceback:
  File "/opt/scancodeio/scanpipe/pipelines/__init__.py", line 121, in execute
    step(self)
  File "/opt/scancodeio/scanpipe/pipelines/scan_package.py", line 109, in run_scancode
    raise ScancodeError(errors)

This should not fail (since this is a recoverable error) but should instead be loaded with the errors as error messages and the scan as output.

aboutcode-org/scancode-toolkit#3614

tdruez added a commit that referenced this issue Dec 5, 2023
tdruez added a commit that referenced this issue Dec 5, 2023
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Dec 5, 2023
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Dec 5, 2023
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Dec 5, 2023
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Dec 5, 2023
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Dec 5, 2023

Improved in #1019

@tdruez tdruez closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants