Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source link broken #3462

Closed
CAH-FlyChen opened this issue Apr 3, 2020 · 10 comments · Fixed by #6421
Closed

source link broken #3462

CAH-FlyChen opened this issue Apr 3, 2020 · 10 comments · Fixed by #6421
Assignees
Milestone

Comments

@CAH-FlyChen
Copy link

CAH-FlyChen commented Apr 3, 2020

only afew package contains source link.
image

image

but i can debug setp into core dll
image

and i can not setp into app dll.eg:CheckGetListPolicyAsync funciton and ApplySorting function
image

@maliming maliming self-assigned this Apr 3, 2020
@maliming maliming modified the milestones: 2.5, 2.4 Apr 3, 2020
@maliming
Copy link
Member

maliming commented Apr 3, 2020

SourceLink.Create.CommandLine doesn't seem to work in net core 3.x anymore.

@maliming maliming modified the milestones: 2.4, 2.5 Apr 3, 2020
@ebicoglu ebicoglu modified the milestones: 2.5, 2.6 Apr 10, 2020
@maliming
Copy link
Member

maliming commented Apr 10, 2020

@KevinBassaDevelopment
Copy link

Any update on this issue? Beeing able to debug the abp packages is really essential.

@maliming
Copy link
Member

hi, @KevinBassaDevelopment This problem is related to the .net core, we are waiting for the above issue.

https://github.com/shiftkey/dotnetcore-sourcelink-test-bug
shiftkey/dotnetcore-sourcelink-test-bug#1

@windsOne
Copy link

@maliming please quick ,very thanks

@maliming
Copy link
Member

There is nothing I can do except waiting. #3462 (comment)

@yanxiaodi
Copy link

Just leave a workaround if you have the below issue:
If you are using Azure DevOps pipeline to build abp applications, you may see the error:

##[error]/home/vsts/.nuget/packages/sourcelink.create.commandline/2.8.3/build/SourceLink.Create.CommandLine.targets(30,5): Error : unable to convert OriginUrl: https://xxxx

FYI: https://support.abp.io/QA/Questions/60/Azure-Devops-Build-Pipeline-SourceLinkCreateCommandLine-Error
You can edit the common.props file in your solution folder and delete the reference to the SourceLink.Create.CommandLine package then the pipeline can work correctly.

@Enissay
Copy link

Enissay commented Nov 15, 2020

/root/.nuget/packages/sourcelink.create.commandline/2.8.3/build/SourceLink.Create.CommandLine.targets(30,5): error : unable to convert OriginUrl: https://gitlab-ci-token:....
The same issue we face when trying to build a nuget package. @yanxiaodi workaround solves the issue. I wonder if there's any premanent fix!

maliming added a commit that referenced this issue Dec 1, 2020
@maliming maliming removed this from the backlog milestone Dec 1, 2020
@maliming maliming added this to the 4.1-preview milestone Dec 1, 2020
@sevenNightL
Copy link

There is nothing I can do except waiting. #3462 (comment)

fixed this problem at now?

@maliming
Copy link
Member

@sevenNightL
See #6702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants