-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize hide abp end points #17151
Optimize hide abp end points #17151
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #17151 +/- ##
==========================================
+ Coverage 53.16% 53.21% +0.05%
==========================================
Files 3011 3011
Lines 93815 93815
==========================================
+ Hits 49876 49923 +47
+ Misses 43939 43892 -47 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, can you remove the changes that you made in AbpSelectTagHelperService.cs and AbpInputTagHelperService.cs. Because, they are not subject to this PR, please create a new PR for them.
Also, I think we can directly remove schemas that start with the Volo.
prefix (ActionUrlPrefixes
), what do you think?
Hi @EngincanV |
Thanks for your contribution @masoodkhoshgard 🎉 |
hi This pr has a bug. |
Resolves #14187
When using option HideAbpEndpoints, it only deletes the endpoints and still displays the schemas. With this correction, this issue will be resolved.