Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize hide abp end points #17151

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

masoodkhoshgard
Copy link
Contributor

Resolves #14187

When using option HideAbpEndpoints, it only deletes the endpoints and still displays the schemas. With this correction, this issue will be resolved.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #17151 (1332be6) into dev (d6f97d8) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 1332be6 differs from pull request most recent head 8b6a375. Consider uploading reports for the commit 8b6a375 to get more accurate results

@@            Coverage Diff             @@
##              dev   #17151      +/-   ##
==========================================
+ Coverage   53.16%   53.21%   +0.05%     
==========================================
  Files        3011     3011              
  Lines       93815    93815              
==========================================
+ Hits        49876    49923      +47     
+ Misses      43939    43892      -47     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EngincanV EngincanV self-requested a review July 19, 2023 10:09
@EngincanV EngincanV added this to the 7.4-preview milestone Jul 20, 2023
Copy link
Member

@EngincanV EngincanV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you remove the changes that you made in AbpSelectTagHelperService.cs and AbpInputTagHelperService.cs. Because, they are not subject to this PR, please create a new PR for them.

Also, I think we can directly remove schemas that start with the Volo. prefix (ActionUrlPrefixes), what do you think?

@masoodkhoshgard
Copy link
Contributor Author

Hi @EngincanV
Of course, I will remove the AbpSelectTagHelperService.cs and AbpInputTagHelperService.cs.
I already added PR #17129 for this
If remove the schemas that start with the Volo. prefix (ActionUrlPrefixes), it will also Volo.Abp.Http.RemoteServiceErrorInfo,
Volo.Abp.Http.RemoteServiceErrorResponse and
Volo.Abp.Http.RemoteServiceValidationErrorInfo
removes that causes an error

@EngincanV EngincanV merged commit 4429ed5 into abpframework:dev Jul 20, 2023
1 check passed
@EngincanV
Copy link
Member

Thanks for your contribution @masoodkhoshgard 🎉

maliming added a commit that referenced this pull request Aug 30, 2023
@maliming
Copy link
Member

hi

This pr has a bug.

#17510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants