Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await initial pushable read #109

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: await initial pushable read #109

merged 1 commit into from
Dec 2, 2023

Conversation

achingbrain
Copy link
Owner

Without this the first write to a byte/length-prefixed or protobuf stream doesn't wait for the message to be read.

@achingbrain
fix: await intial pushable read
767ea07 
Without this the first write to a byte/length-prefixed or protobuf
stream doesn't wait for the message to be read.
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

achingbrain added a commit to libp2p/js-libp2p that referenced this pull request Dec 2, 2023
@achingbrain
fix: do not wait for stream reads and writes at the same time
1eb0b42 
achingbrain/it#109 will change the behaviour
of byte streams to wait for the first read before resolving the promise
returned from the first write in order to have guarentees that once
the promise has resolved, the data has been sent so update the tests
etc to remove deadlocks.
@achingbrain achingbrain mentioned this pull request Dec 2, 2023
Merged
3 tasks
achingbrain added a commit to libp2p/js-libp2p that referenced this pull request Dec 2, 2023
@achingbrain
fix: do not wait for stream reads and writes at the same time (#2290)
10ea197 
achingbrain/it#109 will change the behaviour
of byte streams to wait for the first read before resolving the promise
returned from the first write in order to have guarentees that once
the promise has resolved, the data has been sent so update the tests
etc to remove deadlocks.
@achingbrain achingbrain merged commit 011fb6b into main Dec 2, 2023
21 checks passed
@achingbrain achingbrain deleted the fix/await-initial-pushable-read branch December 2, 2023 13:20
github-actions bot pushed a commit that referenced this pull request Dec 2, 2023
@semantic-release-bot
chore(release): 1.0.6 [skip ci]
808bd33 
## [it-byte-stream-v1.0.6](it-byte-stream-v1.0.5...it-byte-stream-v1.0.6) (2023-12-02)

### Bug Fixes

* await initial pushable read ([#109](#109)) ([011fb6b](011fb6b))

### Trivial Changes

* rename master to main ([#108](#108)) ([86d5c1f](86d5c1f))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.4 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.0.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain