Actually use 'dockerdContainerResources' to set resources on the dind…

[thrawny]

… container

Fixes #242

[mumoshu]

Awesome! Thanks for fixing it @thrawny ☺️

[martinm82]

Hi all, we are encountering an issue where setting resource limits are not taken into account when using the DinD approach.

I am wondering whether the expected behaviour got broken by the following change:

#696

The original change did not had a condition when to use the resource limit whereas the commit above adds a condition in case the DockerdWithinRunnerContainer is null or false.

Even here someone was providing an example #277 (comment) which after the change in July won't work anymore.

[mumoshu]

@martinm82 Hey! Which setup are you referring, runner container + the dind sidecar, or a hybrid container of runner + dind?

[mumoshu]

AFAICS, the changes made in #696 is valid, because DockerdContainerResources makes sense only when you configured the runner to have the dind sidecar.

[martinm82]

I am referring to runner + dind and had the impression that for this case the resources would as well be supported.

To me it seems that the example provided here #277 (comment) wouldn't work with the change from #696.

[mumoshu]

@martinm82 Thanks! But I'm confused. #696 should have nothing to do with the example introduced in #277 (comment).
If I'm not missing anything, it should be #1383 if it's broken.
Probably you could instead use something like the below as a workaround that works today?

spec:
  template:
    spec:
      containers:
      - name: runner
        resources:
          # your resource requests/limits here