fix: use environment variable for PIP_ROOT_USER_ACTION
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option does not exists in every pip version, using the environment variable allows for pip not to fail in this case.
jmarrec
reviewed
Mar 12, 2024
| ./python -m ensurepip | ||
| ./python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location --root-user-action=ignore | ||
| ./python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location |
There was a problem hiding this comment.
Note that this same issue occurs for linux runners: https://github.com/jmarrec/python-versions/actions/runs/8250002087/job/22564591071#step:6:30
There was a problem hiding this comment.
On Linux, where python is built from sources, the issue occurs for non latest patch versions or EOL versions.
All latest patch versions for python 3.7+ are embedding pip>=22.1 which support this options.
9 tasks
aparnajyothi-y
approved these changes
Apr 18, 2024
priya-kinthali
approved these changes
Apr 18, 2024
5 tasks
HarithaVattikuti
approved these changes
Apr 25, 2024
5 tasks
mayeut
added a commit
to mayeut/python-versions
that referenced
this pull request
Apr 26, 2024
This extends the fix from actions#259 since every platform for 3.8.10 / 3.9.13 has been rebuilt instead of just macOS arm64 being added. The regression was introduced in actions#223
Diviloper
added a commit
to MobilityDB/PyMEOS
that referenced
this pull request
Apr 27, 2024
HarithaVattikuti
pushed a commit
that referenced
this pull request
Apr 29, 2024
* fix: error out on install failure in "Apply build artifact to the local machine" step * fix: error out on pip installation / update failure * fix: use environment variable for `PIP_ROOT_USER_ACTION` This extends the fix from #259 since every platform for 3.8.10 / 3.9.13 has been rebuilt instead of just macOS arm64 being added. The regression was introduced in #223
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Jul 24, 2024
These were excluded in 9ad28c3 (gitpython-developers#1817) due to actions/setup-python#808, which was later fixed by actions/python-versions#259. Because Python 3.7 has been end-of-life for a while, it is very unlikely to have AArch64 builds added in python-versions for use on GitHub Actions CI runners (preinstalled or via setup-python).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option does not exists in every pip version, using the environment variable allows for pip not to fail in this case.
This is required to build macOS arm64 packages of python 3.8 & 3.9 as requested in actions/setup-python#808
builds can be seen in https://github.com/mayeut/python-versions/actions/workflows/build-python-packages.yml