Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add .zip extension to Windows package downloads for Expand-Archive Compatibility #916

Merged

Conversation

priyagupta108
Copy link
Contributor

Description:
This pull request addresses compatibility issues on Windows by ensuring that filename for Python and PyPy package downloads explicitly include the .zip extension. This change allows the Expand-Archive command to function correctly on Windows self-hosted runners.

Related issue:
#819
#904

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@priyagupta108 priyagupta108 requested a review from a team as a code owner July 26, 2024 09:06
@jortony
Copy link

jortony commented Sep 19, 2024

I realize that this is a little late, but the code base can be simplified by removing all checks and use of Powershell here. Since the Powershell commands for archive are based on the dotnet APIs it would be much more efficient and less error prone to call them directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants