Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to return proxy agent dispatcher for compatibility with latest octokit packages #1547

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

takost
Copy link
Contributor

@takost takost commented Oct 5, 2023

Add function to return proxy agent dispatcher for compatibility with latest octokit packages.
Octokit docs

@takost takost requested a review from a team as a code owner October 5, 2023 14:24
Copy link
Member

@pje pje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unfamiliar with undici, so I had to do some research :)

Overall I'm happy to ✅ — my only question is really on the necessity of bumping the major version of the package, but I'll defer to your judgment there!

@takost takost merged commit c8d1588 into main Oct 6, 2023
10 checks passed
},
"dependencies": {
"tunnel": "^0.0.6"
"tunnel": "^0.0.6",
"undici": "^5.25.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takost,

When updating today, I noticed that size of my action bloated by 15k lines because undici was included as a dependency.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same for me. I've raised a ticket for the issue #1621

@@ -3,6 +3,7 @@
import * as http from 'http'
import * as httpm from '../lib/'
import * as pm from '../lib/proxy'
import {ProxyAgent} from 'undici'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line causes the "lightweight" client size to increase 3x times by 1Mb of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants