Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Fix potential XSS issue when rendering form legends #8349

Merged
merged 2 commits into from
May 31, 2024

Conversation

deivid-rodriguez
Copy link
Member

No description provided.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3-0-stable@cce08cb). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             3-0-stable    #8349   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4945           
  Branches              ?        0           
=============================================
  Hits                  ?     4905           
  Misses                ?       40           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio self-requested a review May 31, 2024 14:38
@javierjulio javierjulio changed the title 3.2 stable: Fix potential XSS issue when rendering form legends Backport Fix potential XSS issue when rendering form legends May 31, 2024
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deivid-rodriguez deivid-rodriguez merged commit 994880d into 3-0-stable May 31, 2024
16 checks passed
@deivid-rodriguez deivid-rodriguez deleted the legend-xss-backport branch May 31, 2024 14:43
cmanetta pushed a commit to bugcrowd/activeadmin that referenced this pull request Jun 3, 2024
…dmin#8349)

* Fix strange context names

* Escape legend to prevent XSS
4tolexx pushed a commit to velaluqa/activeadmin that referenced this pull request Jul 6, 2024
…dmin#8349)

* Fix strange context names

* Escape legend to prevent XSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants