Repair Mecury and TransFirst (#5206)

* Repair Mecury and TransFirst A previous commit broke these gateways after updating REXML. This commit updates the two gateways so that they can process the XML like it used to. Test Summary Remote: No credentials available for Mercury Could not reach the test server for TransFirst * changelog
activemerchant · Aug 8, 2024 · 3e7aa32 · 3e7aa32
1 parent f52d344
commit 3e7aa32
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 4 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -2,6 +2,7 @@
 = ActiveMerchant CHANGELOG
 
 == HEAD
+* Mercury, TransFirst: Repair gateways following updates to `rexml` [aenand] #5206.
 
 = Version 1.137.0 (August 2, 2024)
 

diff --git a/lib/active_merchant/billing/gateways/mercury.rb b/lib/active_merchant/billing/gateways/mercury.rb
@@ -349,7 +349,9 @@ def escape_xml(xml)
       end
 
       def unescape_xml(escaped_xml)
-        escaped_xml.gsub(/\&gt;/, '>').gsub(/\&lt;/, '<')
+        xml = escaped_xml.gsub(/\&gt;/, '>')
+        xml.slice! "<?xml version=\"1.0\"?>" # rubocop:disable Style/StringLiterals
+        xml
       end
     end
   end

diff --git a/lib/active_merchant/billing/gateways/trans_first.rb b/lib/active_merchant/billing/gateways/trans_first.rb
@@ -166,6 +166,9 @@ def parse(data)
           end
         end
 
+        response
+      rescue StandardError
+        response[:message] = data&.to_s&.strip
         response
       end
 

diff --git a/test/unit/gateways/mercury_test.rb b/test/unit/gateways/mercury_test.rb
@@ -126,7 +126,7 @@ def test_transcript_scrubbing
 
   def successful_purchase_response
     <<~RESPONSE
-      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult>
+      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult><?xml version="1.0"?>
       <RStream>
         <CmdResponse>
           <ResponseOrigin>Processor</ResponseOrigin>
@@ -163,7 +163,7 @@ def successful_purchase_response
 
   def failed_purchase_response
     <<~RESPONSE
-      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult>
+      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult><?xml version="1.0"?>
       <RStream>
         <CmdResponse>
           <ResponseOrigin>Server</ResponseOrigin>
@@ -179,7 +179,7 @@ def failed_purchase_response
 
   def successful_refund_response
     <<~RESPONSE
-      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult>
+      <?xml version="1.0" encoding="utf-8"?><soap:Envelope xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"><soap:Body><CreditTransactionResponse xmlns="http://www.mercurypay.com"><CreditTransactionResult><?xml version="1.0"?>
       <RStream>
         <CmdResponse>
           <ResponseOrigin>Processor</ResponseOrigin>

diff --git a/test/unit/gateways/trans_first_test.rb b/test/unit/gateways/trans_first_test.rb
@@ -15,6 +15,16 @@ def setup
     @amount = 100
   end
 
+  def test_missing_field_response
+    @gateway.stubs(:ssl_post).returns(missing_field_response)
+
+    response = @gateway.purchase(@amount, @credit_card, @options)
+
+    assert_failure response
+    assert response.test?
+    assert_equal 'Missing parameter: UserId.', response.message
+  end
+
   def test_successful_purchase
     @gateway.stubs(:ssl_post).returns(successful_purchase_response)