BT: Add support for network tokens #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
force-pushed
the
ECS-2957_bt_update
branch
from
15dd1ae
to
6449d06
Compare
BritneyS
reviewed
Jul 18, 2023
Closed
almalee24
reviewed
Jul 26, 2023
aenand
force-pushed
the
ECS-2957_bt_update
branch
3 times, most recently
from
a9d1a13
to
241ce3d
Compare
aenand
force-pushed
the
ECS-2957_bt_update
branch
from
241ce3d
to
1753485
Compare
BritneyS
approved these changes
Jul 27, 2023
ECS-2899 Braintree supports bring your own Network Tokens via their SDK starting in Major version 4.0. This commit adds logic to update the BT gem version used by the CI/CD tests to 4.0 and adds support for using Network Tokens on the Braintree Blue gateway. Remote Tests: 104 tests, 554 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remove android pay from BT
aenand
force-pushed
the
ECS-2957_bt_update
branch
from
1753485
to
2659bbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for network tokens to the Braintree gateway. The gateway class utilizes the Braintree SDK which added support for network tokens in major version 4. This commit updates the logic to add support for tagging NT as per the BT docs but does not require the CI tests to move to the new BT version.
Question for reviewers: Should we wait for the BT ruby gem to get updated in the repo's CI tests before merging this?