Nuvie/SafeCharge: Add unreferenced refund field #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
requested changes
Jul 17, 2023
| post[:sg_CCToken] = token | ||
| post[:sg_ExpMonth] = exp_month | ||
| post[:sg_ExpYear] = exp_year | ||
|
|
||
| commit(post) | ||
| if options[:unreferenced_refund] == true |
There was a problem hiding this comment.
Instead of duplicating the commit(post) statement with this logic, could you instead add an unless to the end of line 76?
post[:sg_TransactionID] = transaction_id unless options[:unreferenced_refund]
I think this would make the change a little bit more DRY
There was a problem hiding this comment.
yep I totally agree! I was completely brain fogged and was already fixing it when the linter failed lol, thanks!
yunnydang
force-pushed
the
add_field_unreferenced_refund_safe_charge
branch
from
f490c77
to
c91b917
Compare
I was playing around with trying to do something similar to this but didnt get far. After stepping away for a bit, I figured it out, thanks! |
yunnydang
force-pushed
the
add_field_unreferenced_refund_safe_charge
branch
2 times, most recently
from
8ae538c
to
448ab0b
Compare
yunnydang
force-pushed
the
add_field_unreferenced_refund_safe_charge
branch
2 times, most recently
from
775bca5
to
011e4d6
Compare
yunnydang
force-pushed
the
add_field_unreferenced_refund_safe_charge
branch
from
011e4d6
to
8dd0d54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
I didn't include a unit test because this fields purpose is to exclude sending the sg_TransactionID and not meant to return anything.
Local:
5545 tests, 77509 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6573% passed
Unit:
25 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
32 tests, 89 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed