Paysafe: Truncate address fields #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachelkirk
approved these changes
Jul 27, 2023
| address1: "This is an extremely long address, it is unreasonably long and we can't allow it.", | ||
| address2: "This is an extremely long address2, it is unreasonably long and we can't allow it.", | ||
| city: 'Lake Chargoggagoggmanchauggagoggchaubunagungamaugg', | ||
| state: 'NC', |
There was a problem hiding this comment.
Is this a lake in Australia? I feel like they'd have a lake named something like this. And if that's the case, how dare you truncate it?!?!
| assert_match(/"street":"This is an extremely long address, it is unreasona"/, data) | ||
| assert_match(/"street2":"This is an extremely long address2, it is unreason"/, data) | ||
| assert_match(/"city":"Lake Chargoggagoggmanchauggagoggchaubuna"/, data) | ||
| end.respond_with(successful_purchase_response) |
There was a problem hiding this comment.
I'm saddened to see the disrespect shown to this made up lake.
Limits the length of address fields, according to Paysafe docs
jcreiff
force-pushed
the
paysafe_truncate_address_fields
branch
from
ca7cb48
to
0ff6eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the length of address fields, according to Paysafe docs
LOCAL
5560 tests, 77697 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
760 files inspected, no offenses detected
UNIT
19 tests, 95 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
REMOTE
34 tests, 83 assertions, 8 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
76.4706% passed
CER-746