Cybersource: Add merchant_id #4844
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
requested changes
Jul 31, 2023
Yes, I'll make those changes. I just realized that @options[:merchant_id] was different than this new field |
almalee24
force-pushed
the
cybersource_merchant_id
branch
from
37e6cce
to
8cf9338
Compare
BritneyS
approved these changes
Aug 1, 2023
| @@ -556,7 +556,7 @@ def add_line_item_data(xml, options) | |||
| end | |||
|
|
|||
| def add_merchant_data(xml, options) | |||
| xml.tag! 'merchantID', @options[:login] | |||
| xml.tag! 'merchantID', options[:merchant_id] || @options[:login] | |||
There was a problem hiding this comment.
options vs @options here is interesting. This makes sense, since it looks like @options is a hash for "gateway options" and options is a hash for "request options", so merchant_id is passed after the gateway was originally created.
aenand
requested changes
Aug 4, 2023
| string_to_sign = { | ||
| host: host, | ||
| date: gmtdatetime, | ||
| "(request-target)": "#{http_method} /pts/v2/#{resource}", | ||
| digest: digest, | ||
| "v-c-merchant-id": @options[:merchant_id] | ||
| "v-c-merchant-id": options[:merchant_id] || @options[:merchant_id] |
There was a problem hiding this comment.
After reviewing the REST docs I made a mistake in the requirements. I believe we should only override it for the HTTP header, not the Signature.
almalee24
force-pushed
the
cybersource_merchant_id
branch
from
8cf9338
to
fc83329
Compare
almalee24
force-pushed
the
cybersource_merchant_id
branch
from
fc83329
to
7f9cfca
Compare
Set the merchantId filed to options[:merchant_id] instead of @options[:login] if available. Cybersource Unit: 136 tests, 641 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed CybersourceRest Unit: 30 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
cybersource_merchant_id
branch
from
7f9cfca
to
21d987d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the merchantId filed to options[:merchant_id] instead of @options[:login] if available.
Unit: 136 tests, 641 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed