SecurionPay: Enable securionPay API to be used as shift4_v2 #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierpedrozaing
force-pushed
the
SER-653_enable_shift4_v2_using_securion_pay_api
branch
7 times, most recently
from
b3a2fb4
to
f7c8420
Compare
sinourain
reviewed
Aug 3, 2023
jherreraa
force-pushed
the
SER-653_enable_shift4_v2_using_securion_pay_api
branch
from
f7c8420
to
ab7fa73
Compare
Heavyblade
reviewed
Aug 8, 2023
There was a problem hiding this comment.
@javierpedrozaing / @jherreraa great job adding test coverage on this, leaved some comments for your consideration.
javierpedrozaing
force-pushed
the
SER-653_enable_shift4_v2_using_securion_pay_api
branch
2 times, most recently
from
a046948
to
72c25fb
Compare
jherreraa
force-pushed
the
SER-653_enable_shift4_v2_using_securion_pay_api
branch
from
72c25fb
to
4836fc9
Compare
Description ------------------------- [SER-653](https://spreedly.atlassian.net/browse/SER-653) [SER-654](https://spreedly.atlassian.net/browse/SER-654) [SER-655](https://spreedly.atlassian.net/browse/SER-655) [SER-662](https://spreedly.atlassian.net/browse/SER-662) Shift4 purchased Securion Pay and is now using their API, that's why this commit enable the basic operations with securionPay to be used as shift4_v2 Unit test ------------------------- Finished in 0.150258 seconds. 34 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 226.28 tests/s, 1271.15 assertions/s Remote test ------------------------- Finished in 28.137188 seconds. 30 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1.07 tests/s, 3.66 assertions/s Rubocop ------------------------- 760 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
SER-653_enable_shift4_v2_using_securion_pay_api
branch
from
4836fc9
to
a4f6b89
Compare
|
I think we're good to close this, but let me know if I'm wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-653
SER-654
SER-655
SER-661
SER-662
SER-663
Shift4 purchased Securion Pay and is now using their API, that's why
this commit enables the basic operations with securionPay to be used as shift4_v2
Note: WIP, eventually we'll add stored credentials.
Unit test
Finished in 0.150258 seconds.
34 tests, 191 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
226.28 tests/s, 1271.15 assertions/s
Remote test
Finished in 28.137188 seconds.
30 tests, 103 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
1.07 tests/s, 3.66 assertions/s
Rubocop
760 files inspected, no offenses detected