Wordline (Global Collect): Add agent numeric code and house number field #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
reviewed
Aug 2, 2023
There was a problem hiding this comment.
@yunnydang I think this looks good -- while we are correcting this, can you also make the same housenumber/street correction for the shipping address logic too?
yunnydang
force-pushed
the
add_housenumber_and_agent_numberic_code_fields
branch
from
abe2e31
to
fd5241e
Compare
yunnydang
force-pushed
the
add_housenumber_and_agent_numberic_code_fields
branch
from
fd5241e
to
9fa4dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local:
5563 tests, 77664 assertions, 1 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6405% passed
Unit:
44 tests, 226 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
51 tests, 133 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed