Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapyd: Change nesting of description, statement_descriptor, complete_… #4849

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

jcreiff
Copy link
Contributor

@jcreiff jcreiff commented Aug 7, 2023

…payment_url, and error_payment_url

According to Rapyd docs, description and statement_descriptor should be at the top level of the request body.

When storing a payment method at Rapyd, the complete_payment_url and error_payment_url are nested in the payment_method object. (See Rapyd docs for "Create customer with payment method".) On other operations, these fields appear at the top level of the request.

CER-768

LOCAL
5564 tests, 77726 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

760 files inspected, no offenses detected

UNIT
23 tests, 112 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

REMOTE
31 tests, 88 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@jcreiff jcreiff requested review from aenand and a team August 7, 2023 18:59
Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a remote test for this or do we already have some for this?

lib/active_merchant/billing/gateways/rapyd.rb Show resolved Hide resolved
lib/active_merchant/billing/gateways/rapyd.rb Outdated Show resolved Hide resolved
@jcreiff
Copy link
Contributor Author

jcreiff commented Aug 8, 2023

Can we add a remote test for this or do we already have some for this?

The remote tests set all four of these fields in @options by default, so I think we are sending them on all the tests for auth/purchase/store already. Is there a specific test assertion you would recommend adding?

@jcreiff jcreiff force-pushed the rapyd_descriptors_and_urls branch 2 times, most recently from d35334e to 07a31e0 Compare August 8, 2023 14:38
Copy link
Contributor

@aenand aenand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jcreiff jcreiff merged commit a0538f5 into master Aug 9, 2023
5 checks passed
@jcreiff jcreiff deleted the rapyd_descriptors_and_urls branch August 9, 2023 19:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants