Rapyd: Update handling of ewallet and billing address phone
#4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
commented
Aug 18, 2023
| @@ -107,7 +107,7 @@ def test_successful_purchase_using_ach | |||
| end | |||
|
|
|||
| def test_successful_purchase_with_options | |||
| options = @options.merge(metadata: @metadata, ewallet_id: 'ewallet_1a867a32b47158b30a8c17d42f12f3f1') | |||
| options = @options.merge(metadata: @metadata, ewallet_id: 'ewallet_897aca846f002686e14677541f78a0f4') | |||
There was a problem hiding this comment.
After updating the field name to ewallet, this test failed because evidently the old ID doesn't exist on the test account, so I created a new one
jcreiff
force-pushed
the
rapyd_bug_fixes
branch
from
b47c84c
to
77d0757
Compare
Changes `ewallet_id` to `ewallet` to match Rapyd's specifications Adds handling for alternate method of passing `phone_number` in the `billing_address` object CER-843, CER-844
jcreiff
force-pushed
the
rapyd_bug_fixes
branch
from
77d0757
to
b7e4193
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ewallet_idtoewalletto match Rapyd's specificationsAdds handling for alternate method of passing
phone_numberin thebilling_addressobjectCER-843, CER-844
LOCAL
5581 tests, 77780 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
763 files inspected, no offenses detected
UNIT
25 tests, 124 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
REMOTE
31 tests, 89 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed