Braintree: Add sca_exemption #4864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
reviewed
Aug 18, 2023
| @@ -673,6 +673,8 @@ def create_transaction_parameters(money, credit_card_or_vault_id, options) | |||
|
|
|||
| add_3ds_info(parameters, options[:three_d_secure]) | |||
|
|
|||
| parameters[:sca_exemption] = options[:three_ds_exemption_type] if options[:three_ds_exemption_type] | |||
There was a problem hiding this comment.
There will likely be a set amount of standard exemption types across gateways. What if we standardize them inside the options[:three_d_secure] hash and then map them to the gateway's specific values kind of like STANDARD_ERROR_CODE
THREE_DS_EXEMPTIONS = {
'low_value': 'low_value',
'another_exemption': 'exemption_another'
}
There was a problem hiding this comment.
Looking around AM quite a few gateways look for something like options[:sca_exemption] so maybe we standardize on that field?
There was a problem hiding this comment.
:sca_exemption is what we map for Adyen & Barclaycard and for Redsys is what the field the customer sends us. three_ds_exemption_type is the field that customer sends us but we map it on our side to be specific to the gateway.
well done!To specifiy the SCA exemption that a trasaction will be claming. Remote: 105 tests, 559 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 94 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
braintree_sca_exemption
branch
from
ef01692
to
f6b99f1
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To specifiy the SCA exemption that a trasaction will be claming.
Remote:
105 tests, 559 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit:
94 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed