Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree Blue: Update the credit card details transaction hash #4865

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

yunnydang
Copy link
Contributor

This is to allow AM to include the prepaid, debit, and issuing bank fields on the credit card details object for transactions.

Local:
5582 tests, 77736 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6596% passed

Unit:
95 tests, 209 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
106 tests, 515 assertions, 4 failures, 4 errors, 0 pendings, 0 omissions, 0 notifications
92.4528% passed (the ones that failed are authentication errors)

@yunnydang yunnydang requested a review from a team August 18, 2023 18:35
@yunnydang yunnydang self-assigned this Aug 18, 2023
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@yunnydang yunnydang force-pushed the update_transaction_hash_credit_card_details branch from 3b4a164 to 8cd93c2 Compare August 21, 2023 19:28
@yunnydang yunnydang merged commit 8cd93c2 into master Aug 21, 2023
5 checks passed
@yunnydang yunnydang deleted the update_transaction_hash_credit_card_details branch August 21, 2023 19:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants