Braintree: return global_id in response #4884
Conversation
rachelkirk
force-pushed
the
CER-868_braintree_global_id
branch
from
cc8c91f
to
92d4f52
Compare
rachelkirk
force-pushed
the
CER-868_braintree_global_id
branch
2 times, most recently
from
f01746c
to
6de1589
Compare
The unit tests are testing what is going into the requests, since there's nothing about global_id in the request and it's only returned in the response I can't really write a unit test for it. Those risk data tests have things that are included in the request headers |
Nice! Thanks for clarifying I just peeked super quick at the unit tests, awesome work! |
CER-868 This field needs to be added to the transaction_hash method to be returned in the response. This also updates the Braintree gem, which was need to make these fields available Remote 107 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 31.7757% passed Unit 95 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 41.0526% passed Local 5599 tests, 77770 assertions, 0 failures, 56 errors, 0 pendings, 0 omissions, 0 notifications 98.9998% passed
rachelkirk
force-pushed
the
CER-868_braintree_global_id
branch
from
6de1589
to
4b068b6
Compare
CER-868
This field needs to be added to the transaction_hash method to be returned in the response. The Braintree gem required an update to make the
payment_receiptobject availableI did not include a unit test because I'm trying to get something returned in the response and according to the Braintree docs, it does not appear that anything should be passed in the request to trigger this coming back.
Remote
107 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
31.7757% passed
Unit
95 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
41.0526% passed
Local
5599 tests, 77770 assertions, 0 failures, 56 errors, 0 pendings, 0 omissions, 0 notifications
98.9998% passed