SumUp Gateway: Fix refund method #4924

sinourain · 2023-10-20T03:01:30Z

Description

Fix refund method to SumUp Gateway adapter.

This are the relevant links to review the implementation:

Refund a transaction

Tickets for Spreedly reference
SER-836

Note: SumUp has shared with us an account to test with which we can refund a purchase

Unit test

Finished in 32.469516 seconds.
5638 tests, 78183 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote test

173.64 tests/s, 2407.89 assertions/s

Rubocop

773 files inspected, no offenses detected

javierpedrozaing

LGTM just I left some comments for you consideration. 👍🏻

javierpedrozaing · 2023-10-23T22:19:43Z

test/remote/gateways/remote_sum_up_test.rb

@@ -123,6 +123,26 @@ def test_failed_void_invalid_checkout_id
    assert_equal 'Resource not found', response.message
  end

+  def test_successful_refund
+    gateway = SumUpGateway.new(fixtures(:sum_up_testing))


Maybe we can find a better name and include it in the fixtures.yml file, to keep in mind that we need to use this credentials as well to run remote test.

javierpedrozaing · 2023-10-24T11:10:43Z

lib/active_merchant/billing/gateways/sum_up.rb

@@ -36,8 +36,7 @@ def void(authorization, options = {})

      def refund(money, authorization, options = {})
        transaction_id = authorization.split('#')[-1]


Split is not necessary here

In fact is actually needed due the way that authorization_from builds the reference, now is that the better way ?, maybe not:

transaction_id = authorization.split('#').last

javierpedrozaing · 2023-10-24T11:22:07Z

lib/active_merchant/billing/gateways/sum_up.rb

-        return false unless %w(PENDING EXPIRED PAID).include?(response[:status])
+        return false unless %w(PENDING EXPIRED PAID REFUND).include?(response[:status])
+
+        return true if response[:transactions].blank?


since you are returning a proper response for refund, I think this return true is not needed, unless for other transaction we have empty responses.

Heavyblade

@sinourain left some complementary PR comments

Heavyblade · 2023-10-25T20:09:49Z

lib/active_merchant/billing/gateways/sum_up.rb

@@ -36,8 +36,7 @@ def void(authorization, options = {})

      def refund(money, authorization, options = {})
        transaction_id = authorization.split('#')[-1]


In fact is actually needed due the way that authorization_from builds the reference, now is that the better way ?, maybe not:

transaction_id = authorization.split('#').last

lib/active_merchant/billing/gateways/sum_up.rb

Heavyblade · 2023-10-25T21:41:58Z

test/remote/gateways/remote_sum_up_test.rb

+    gateway = SumUpGateway.new(fixtures(:sum_up_testing))
+    purchase = gateway.purchase(@amount, @credit_card, @options)
+    assert_success purchase
+    assert_equal 'PAID', purchase.message


💬 Comment:

Do we need all those assertions on the part of the code that is just the context/preparation for the actual test that is going to be refund?, there are 7 assertions before the refund request is actually fired and that request only has 2 assertions, are we testing purchase or refund?

Heavyblade · 2023-10-25T21:43:02Z

test/remote/gateways/remote_sum_up_test.rb

@@ -123,6 +123,26 @@ def test_failed_void_invalid_checkout_id
    assert_equal 'Resource not found', response.message
  end

+  def test_successful_refund


💬 Comment:

Would be great to actually a test that covers a partial refund.

naashton

Just a few comments, generally looks good though 👍

naashton · 2023-11-06T15:53:28Z

test/remote/gateways/remote_sum_up_test.rb

+  #
+  # For this example configure in the fixtures => :sum_up_account_for_successful_purchases
+  def test_successful_refund
+    gateway = SumUpGateway.new(fixtures(:sum_up_account_for_successful_purchases))


Can you share the credentials to test this and also create an entry in the fixtures for sum_up_account_for_successful_purchases?

naashton · 2023-11-06T15:56:39Z

lib/active_merchant/billing/gateways/sum_up.rb

-        return response[:status] if success_from(response)
+      def message_from(succeeded, response)
+        if succeeded
+          return 'SUCCESSFUL' if response.is_a?(Integer)


Change 'SUCCSESSFUL' to 'Succeeded'

lib/active_merchant/billing/gateways/sum_up.rb

naashton · 2023-11-15T20:18:35Z

@sinourain - just a nudge for you to respond to my review

sinourain · 2023-11-15T22:23:29Z

@sinourain - just a nudge for you to respond to my review

thank you. With so many things I had not seen your comments. I'm going to review them.

naashton · 2023-11-16T19:30:22Z

test/remote/gateways/remote_sum_up_test.rb

@@ -1,3 +1,4 @@
+require 'pry'


You can remove this require statement

naashton · 2023-11-16T20:34:11Z

test/remote/gateways/remote_sum_up_test.rb

+  def test_successful_refund
+    gateway = SumUpGateway.new(fixtures(:sum_up_account_for_successful_purchases))
+    purchase = gateway.purchase(@amount, @credit_card, @options)
+    transaction_id = purchase.params['transaction_id']


We should assert the transaction_id here, otherwise the test throws an error if the value is nil

naashton · 2023-11-16T20:34:19Z

test/remote/gateways/remote_sum_up_test.rb

+  def test_successful_partial_refund
+    gateway = SumUpGateway.new(fixtures(:sum_up_account_for_successful_purchases))
+    purchase = gateway.purchase(@amount * 10, @credit_card, @options)
+    transaction_id = purchase.params['transaction_id']


Same as above

naashton

Just a few requests to change in the tests, but everything else looks good!

Description ------------------------- Fix refund method to SumUp Gateway adapter. This are the relevant links to review the implementation: - [Refund a transaction](https://developer.sumup.com/docs/api/refund-transaction/) Tickets for Spreedly reference SER-836 Note: SumUp has shared with us an account to test with which you can refund a purchase Unit test ------------------------- Finished in 32.469516 seconds. 5638 tests, 78183 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- 173.64 tests/s, 2407.89 assertions/s Rubocop ------------------------- 773 files inspected, no offenses detected

sinourain force-pushed the Fix_SumUp_gateway_refund_method branch from 89c79e1 to 76330f4 Compare October 20, 2023 20:58

javierpedrozaing reviewed Oct 23, 2023

View reviewed changes

javierpedrozaing reviewed Oct 24, 2023

View reviewed changes

Heavyblade reviewed Oct 25, 2023

View reviewed changes

sinourain force-pushed the Fix_SumUp_gateway_refund_method branch from 76330f4 to 479e803 Compare November 1, 2023 19:19

sinourain requested a review from naashton November 1, 2023 19:21

sinourain marked this pull request as ready for review November 1, 2023 20:55

naashton force-pushed the Fix_SumUp_gateway_refund_method branch from 479e803 to 392dffa Compare November 6, 2023 15:30

naashton requested changes Nov 6, 2023

View reviewed changes

sinourain force-pushed the Fix_SumUp_gateway_refund_method branch from 392dffa to 4c05cb6 Compare November 16, 2023 15:42

sinourain requested a review from naashton November 16, 2023 16:01

naashton reviewed Nov 16, 2023

View reviewed changes

naashton requested changes Nov 16, 2023

View reviewed changes

sinourain force-pushed the Fix_SumUp_gateway_refund_method branch from 4c05cb6 to bd2d111 Compare November 16, 2023 22:39

sinourain requested a review from naashton November 16, 2023 22:43

naashton force-pushed the Fix_SumUp_gateway_refund_method branch from bd2d111 to 781d12f Compare November 17, 2023 15:44

naashton approved these changes Nov 17, 2023

View reviewed changes

naashton merged commit 3b9de1f into master Nov 17, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SumUp Gateway: Fix refund method #4924

SumUp Gateway: Fix refund method #4924

sinourain commented Oct 20, 2023 •

edited

Loading

javierpedrozaing left a comment •

edited

Loading

javierpedrozaing Oct 23, 2023

javierpedrozaing Oct 24, 2023

Heavyblade Oct 25, 2023

javierpedrozaing Oct 24, 2023

Heavyblade left a comment

Heavyblade Oct 25, 2023

Heavyblade Oct 25, 2023

Heavyblade Oct 25, 2023

naashton left a comment

naashton Nov 6, 2023

sinourain Nov 16, 2023

naashton Nov 6, 2023

sinourain Nov 16, 2023

naashton commented Nov 15, 2023

sinourain commented Nov 15, 2023

naashton Nov 16, 2023

naashton Nov 16, 2023

sinourain Nov 16, 2023

naashton Nov 16, 2023

sinourain Nov 16, 2023

naashton left a comment

		@@ -36,8 +36,7 @@ def void(authorization, options = {})

		def refund(money, authorization, options = {})
		transaction_id = authorization.split('#')[-1]

SumUp Gateway: Fix refund method #4924

SumUp Gateway: Fix refund method #4924

Conversation

sinourain commented Oct 20, 2023 • edited Loading

Description

Unit test

Remote test

Rubocop

javierpedrozaing left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Heavyblade left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naashton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naashton commented Nov 15, 2023

sinourain commented Nov 15, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naashton left a comment

Choose a reason for hiding this comment

sinourain commented Oct 20, 2023 •

edited

Loading

javierpedrozaing left a comment •

edited

Loading