GlobalCollect: Fix bug in success_from logic #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DustinHaefele
force-pushed
the
worldline-collect-apple-pay-bug
branch
2 times, most recently
from
db3a96a
to
064bd5a
Compare
almalee24
reviewed
Oct 31, 2023
| @@ -522,8 +522,6 @@ def content_type | |||
| def success_from(action, response) | |||
| return false if response['errorId'] || response['error_message'] | |||
|
|
|||
| return %w(CAPTURED CAPTURE_REQUESTED).include?(response.dig('payment', 'status')) if response.dig('payment', 'paymentOutput', 'paymentMethod') == 'mobile' | |||
There was a problem hiding this comment.
Great catch, I was so confused about this one.
almalee24
approved these changes
Oct 31, 2023
DustinHaefele
force-pushed
the
worldline-collect-apple-pay-bug
branch
2 times, most recently
from
1c8c370
to
3a909a2
Compare
Some applepay transactions that were through global collect direct (ogone) were being marked as failed despite success. The response from direct was slightly different than the standard global collect so the logic wasn't seeing them as successful. Spreedly reference ticket: ECS-3197 remote tests: 55 tests, 144 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.78 tests/s, 2.05 assertions/s unit tests: 45 tests, 230 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1497.80 tests/s, 7655.44 assertions/s
DustinHaefele
force-pushed
the
worldline-collect-apple-pay-bug
branch
from
3a909a2
to
d53e93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apple_pay transactions that were through global collect direct (ogone) were being marked as failed despite success. The response from direct was slightly different than the standard global collect so the logic wasn't seeing them as successful.
Spreedly reference ticket: ECS-3197
remote tests:
54 tests, 141 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
unit tests:
45 tests, 230 assertions, 0 failures, 0 errors, 0 pending, 0 omissions, 0 notifications 100% passed
1497.80 tests/s, 7655.44 assertions/s