Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisaNet Peru: Pass the purchaseNumber in response #4961

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

yunnydang
Copy link
Contributor

This passes along the generated purchaseNumber in the response as Visanet peru does not echo this back to us.

Note: remote test for this gateway are un-available due to outdated credentials and issues with receiving new ones.

Local:
5732 tests, 78643 assertions, 0 failures, 19 errors, 0 pendings, 0 omissions, 0 notifications
99.6685% passed

Unit:
16 tests, 101 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

@yunnydang yunnydang requested a review from a team November 16, 2023 23:36
@yunnydang yunnydang self-assigned this Nov 16, 2023
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and after squinting through the various transaction paths it looks like there isn't any functional logic that will be affected by stashing this field in the response object prior to returning the Response

@yunnydang yunnydang force-pushed the visanet_peru_pass_purchase_number branch from c6bd728 to c0dd853 Compare November 21, 2023 18:59
@yunnydang yunnydang merged commit c0dd853 into master Nov 21, 2023
@yunnydang yunnydang deleted the visanet_peru_pass_purchase_number branch November 21, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants