Support proxy settings with user and password #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenand
force-pushed
the
support-proxy-user-and-password
branch
from
7128508
to
2c40160
Compare
|
To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you! |
|
@aenand @Heavyblade |
|
I'll be reviewing this today/Tuesday, and I should have an update next week for when we can merge it. |
bradbroge
approved these changes
Sep 6, 2024
bradbroge
force-pushed
the
support-proxy-user-and-password
branch
from
2f993e8
to
30c0c5d
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Merchant has proxy settings, but is unable to pass a user and password. Therefore, Active Merchant can't use authenticated proxies.
This Pull Request adds proxy settings with user and password.
Unit Tests (local)
5846 tests, 79235 assertions, 0 failures, 9 errors, 0 pendings, 0 omissions, 0 notifications
99.846% passed
Rubocop
792 files inspected, no offenses detected