ECS-3530 Adyen Format error fix

[jherreraa]

ECS-3530

Summary:

This PR fix format error using NT

Unit tests

Finished in 0.126432 seconds.

121 tests, 641 assertions, 0 failures,
0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote tests

Finished in 609.957316 seconds.

143 tests, 464 assertions, 11 failures,
0 errors, 0 pendings, 0 omissions, 0 notifications 92.3077% passed

0.23 tests/s, 0.76 assertions/s

-> failures not related to change

[almalee24]

There's also a Rubocop error which is why the GitHub actions tests are failing

[DustinHaefele]

I added the conditional back into the app_mpi_data_for_network_tokenization_card method updating the cavv to tokenAuthenticationVerificationValue. It seems to me that the issue in the tests is with ApplePay and GooglePay. We need to be able to differentiate these from the standard network token flow, and continue to pass that value as cavv for apple pay and google pay.

Then we also need to continue to pass the existing recurring_contract info for apple_pay and google pay and only update that when it is a pure network token.

cc: @almalee24 @jherreraa

[DustinHaefele]

I left a couple of individual comments on this one.

We may not need to reach out to Adyen if we handle the situations we left in my second comment.

[DustinHaefele]

Great work on this one Johan, I know this framework can be a bit tricky!

I found another edge case that needs to be handled before we deploy this.

[DustinHaefele]

@jherreraa, Hey, I found one more issue that we need to resolve before merging this. It should be a quick fix though.

Also maybe add at least one test on apple pay and google pay where the new flag is set to false so we make sure that it passes in both cases.

[DustinHaefele]

I think this is the last thing that we need to solidify and then we are good to go on this. I know this has been a long one, thanks for sticking with it!

[almalee24]

This needs to be payment.try(:source) == :network_token && options[:switch_cryptogram_mapping_nt]