Moneris: Update crypt_type for 3DS #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I commented on the ticket for this work because I'm more confused about that, but the code you wrote seems straight forward. |
Update crypt_type to only be one digit by removing leading zero if present. Unit: 54 tests, 294 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 53 tests, 259 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed
almalee24
force-pushed
the
moneris_crypt_type
branch
from
84788bd
to
27ae6b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update crypt_type to only be one digit by removing leading zero if present.
Unit:
54 tests, 294 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote:
53 tests, 259 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed