Braintree: Pass overridden mid into client token for GS 3DS #5166

sinourain · 2024-07-08T22:27:12Z

Summary:

Add merchant_account_id for the Client Token Generate and returns a string which contains all authorization and configuration information that the client needs to initialize the client SDK to communicate with Braintree

ECS-3617 ECS-3607

Remote Test:

Finished in 6.262003 seconds.
7 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
1.12 tests/s, 2.40 assertions/s

Unit Tests:

Finished in 38.744354 seconds.
5956 tests, 79952 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
153.73 tests/s, 2063.58 assertions/s

RuboCop:

798 files inspected, no offenses detected

Heavyblade

Looks pretty much OK, @sinourain left some comments

Heavyblade · 2024-07-09T17:06:58Z

lib/active_merchant/billing/gateways/braintree/token_nonce.rb

@@ -35,8 +35,13 @@ def create_token_nonce_for_payment_method(payment_method)
      end

      def client_token
-        base64_token = @braintree_gateway.client_token.generate
-        JSON.parse(Base64.decode64(base64_token))['authorizationFingerprint']
+        parameters = options[:merchant_account_id] ? { merchant_account_id: options[:merchant_account_id] } : {}


💬 Comment/Style:

nothing big:

base64_token = @braintree_gateway.client_token.generate({ merchant_account_id: options[:merchant_account_id] }.compact)

Heavyblade · 2024-07-09T17:08:14Z

lib/active_merchant/billing/gateways/braintree/token_nonce.rb

+        JSON.parse(Base64.decode64(base64_token))
+      end
+
+      def authorization_fingerprint


❓ Question:

I get the point of calling it authorization_fingerprint instead of client_token but a method just get a key from a hash ?

Make sense, I will remove authorization_fingerprint

Heavyblade · 2024-07-09T17:09:32Z

test/remote/gateways/remote_braintree_token_nonce_test.rb

    assert_not_nil token
  end

+  def test_client_token_generation_with_mid


❓ Question:

so Nraintree Sandbox doesn't care about a valid mid ?, you can just send a '1234' and they are going to provide you with a client token any way ?

Correct, I tried passing multiple values and got a successful result with every field sent including the known field

Heavyblade

one general comment about the approach =>

Shouldn't the approach be to overwrite the mid that is being sent from CORE to initialize the library so you don't have to think on modifing the mid on the client token creation ?, because I'm seeing the library being initialized with the original @options[:merchant_id] so is possible to have the the instance intialized with mid 1234 and the create_token uses the mid 5678

almalee24 · 2024-07-09T19:40:47Z

lib/active_merchant/billing/gateways/braintree/token_nonce.rb

@@ -21,7 +21,7 @@ def url
      def create_token_nonce_for_payment_method(payment_method)


I'm pretty sure this method needs to be updated to take in options because where would we be getting options[:merchant_account_id] from

good catch, I added the changes :)

sinourain · 2024-07-09T21:06:33Z

one general comment about the approach =>

Shouldn't the approach be to overwrite the mid that is being sent from CORE to initialize the library so you don't have to think on modifing the mid on the client token creation ?, because I'm seeing the library being initialized with the original @options[:merchant_id] so is possible to have the the instance intialized with mid 1234 and the create_token uses the mid 5678

good catch, I added the changes :)

DustinHaefele

I think this looks good. I got stuck in the middle of the review trying to figure out what is happening on a certain method so I left a question.

lib/active_merchant/billing/gateways/braintree/token_nonce.rb

DustinHaefele

Thanks for pointing me to the SDK docs. This looks good to me!

Summary: ------------------------------ Add merchant_account_id for the Client Token Generate and returns a string which contains all authorization and configuration information that the client needs to initialize the client SDK to communicate with Braintree [ECS-3617](https://spreedly.atlassian.net/browse/ECS-3617) [ECS-3607](https://spreedly.atlassian.net/browse/ECS-3607) Remote Test: ------------------------------ Finished in 6.262003 seconds. 7 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1.12 tests/s, 2.40 assertions/s Unit Tests: ------------------------------ Finished in 38.744354 seconds. 5956 tests, 79952 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 153.73 tests/s, 2063.58 assertions/s RuboCop: ------------------------------ 798 files inspected, no offenses detected

Summary: ------------------------------ Add merchant_account_id for the Client Token Generate and returns a string which contains all authorization and configuration information that the client needs to initialize the client SDK to communicate with Braintree [ECS-3617](https://spreedly.atlassian.net/browse/ECS-3617) [ECS-3607](https://spreedly.atlassian.net/browse/ECS-3607) Remote Test: ------------------------------ Finished in 6.262003 seconds. 7 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1.12 tests/s, 2.40 assertions/s Unit Tests: ------------------------------ Finished in 38.744354 seconds. 5956 tests, 79952 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 153.73 tests/s, 2063.58 assertions/s RuboCop: ------------------------------ 798 files inspected, no offenses detected Co-authored-by: Luis Urrea <devluisurrea+endava@gmail.com>

…rchant#5166) Summary: ------------------------------ Add merchant_account_id for the Client Token Generate and returns a string which contains all authorization and configuration information that the client needs to initialize the client SDK to communicate with Braintree [ECS-3617](https://spreedly.atlassian.net/browse/ECS-3617) [ECS-3607](https://spreedly.atlassian.net/browse/ECS-3607) Remote Test: ------------------------------ Finished in 6.262003 seconds. 7 tests, 15 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1.12 tests/s, 2.40 assertions/s Unit Tests: ------------------------------ Finished in 38.744354 seconds. 5956 tests, 79952 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 153.73 tests/s, 2063.58 assertions/s RuboCop: ------------------------------ 798 files inspected, no offenses detected Co-authored-by: Luis Urrea <devluisurrea+endava@gmail.com>

Heavyblade reviewed Jul 9, 2024

View reviewed changes

almalee24 requested a review from a team July 9, 2024 19:32

almalee24 reviewed Jul 9, 2024

View reviewed changes

sinourain force-pushed the ECS-3607_braintree_pass_overridden_mid_into_client_token_for_GS_3DS branch 2 times, most recently from c2e616b to 9e4cbcd Compare July 9, 2024 21:05

sinourain force-pushed the ECS-3607_braintree_pass_overridden_mid_into_client_token_for_GS_3DS branch from 9e4cbcd to 47949f1 Compare July 9, 2024 21:17

DustinHaefele reviewed Jul 10, 2024

View reviewed changes

lib/active_merchant/billing/gateways/braintree/token_nonce.rb Show resolved Hide resolved

DustinHaefele approved these changes Jul 11, 2024

View reviewed changes

sinourain force-pushed the ECS-3607_braintree_pass_overridden_mid_into_client_token_for_GS_3DS branch from 47949f1 to eb6bbb6 Compare July 17, 2024 16:00

sinourain force-pushed the ECS-3607_braintree_pass_overridden_mid_into_client_token_for_GS_3DS branch from eb6bbb6 to c7269aa Compare July 17, 2024 16:02

sinourain merged commit 568466b into master Jul 17, 2024
5 checks passed

sinourain deleted the ECS-3607_braintree_pass_overridden_mid_into_client_token_for_GS_3DS branch July 17, 2024 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Braintree: Pass overridden mid into client token for GS 3DS #5166

Braintree: Pass overridden mid into client token for GS 3DS #5166

sinourain commented Jul 8, 2024

Heavyblade left a comment

Heavyblade Jul 9, 2024

Heavyblade Jul 9, 2024

sinourain Jul 9, 2024

Heavyblade Jul 9, 2024

sinourain Jul 9, 2024

Heavyblade left a comment

almalee24 Jul 9, 2024 •

edited

Loading

sinourain Jul 9, 2024

sinourain commented Jul 9, 2024

DustinHaefele left a comment

DustinHaefele left a comment

		@@ -21,7 +21,7 @@ def url
		def create_token_nonce_for_payment_method(payment_method)

Braintree: Pass overridden mid into client token for GS 3DS #5166

Braintree: Pass overridden mid into client token for GS 3DS #5166

Conversation

sinourain commented Jul 8, 2024

Summary:

Remote Test:

Unit Tests:

RuboCop:

Heavyblade left a comment

Choose a reason for hiding this comment

Heavyblade Jul 9, 2024

Choose a reason for hiding this comment

Heavyblade Jul 9, 2024

Choose a reason for hiding this comment

sinourain Jul 9, 2024

Choose a reason for hiding this comment

Heavyblade Jul 9, 2024

Choose a reason for hiding this comment

sinourain Jul 9, 2024

Choose a reason for hiding this comment

Heavyblade left a comment

Choose a reason for hiding this comment

almalee24 Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

sinourain Jul 9, 2024

Choose a reason for hiding this comment

sinourain commented Jul 9, 2024

DustinHaefele left a comment

Choose a reason for hiding this comment

DustinHaefele left a comment

Choose a reason for hiding this comment

almalee24 Jul 9, 2024 •

edited

Loading