-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plexo: Update Network Token implementation #5169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3f72c2
to
ccb8f5d
Compare
Heavyblade
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty much OK @javierpedrozaing, left some comments
Description ------------------------- [SER-1377](https://spreedly.atlassian.net/browse/SER-1377) This commit update the previous implementation of NT in order to use network token instead if card Unit test ------------------------- Finished in 0.033159 seconds. 25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 753.94 tests/s, 4131.61 assertions/s Remote test ------------------------- Finished in 47.41717 seconds. 32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed 0.67 tests/s, 1.31 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected
ccb8f5d
to
b62dab1
Compare
naashton
approved these changes
Jul 16, 2024
javierpedrozaing
added a commit
that referenced
this pull request
Jul 25, 2024
Description ------------------------- [SER-1377](https://spreedly.atlassian.net/browse/SER-1377) This commit update the previous implementation of NT in order to use network token instead if card Unit test ------------------------- Finished in 0.033159 seconds. 25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 753.94 tests/s, 4131.61 assertions/s Remote test ------------------------- Finished in 47.41717 seconds. 32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed 0.67 tests/s, 1.31 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
javierpedrozaing
added a commit
that referenced
this pull request
Jul 25, 2024
Description ------------------------- [SER-1377](https://spreedly.atlassian.net/browse/SER-1377) This commit update the previous implementation of NT in order to use network token instead if card Unit test ------------------------- Finished in 0.033159 seconds. 25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 753.94 tests/s, 4131.61 assertions/s Remote test ------------------------- Finished in 47.41717 seconds. 32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed 0.67 tests/s, 1.31 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
bryansquadup
pushed a commit
to givehub/active_merchant
that referenced
this pull request
Aug 21, 2024
Description ------------------------- [SER-1377](https://spreedly.atlassian.net/browse/SER-1377) This commit update the previous implementation of NT in order to use network token instead if card Unit test ------------------------- Finished in 0.033159 seconds. 25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 753.94 tests/s, 4131.61 assertions/s Remote test ------------------------- Finished in 47.41717 seconds. 32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed 0.67 tests/s, 1.31 assertions/s Rubocop ------------------------- 798 files inspected, no offenses detected Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-1377
This commit update the previous implementation of NT in order to use network token instead if card
Unit test
Finished in 0.033159 seconds.
25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
753.94 tests/s, 4131.61 assertions/s
Remote test
32 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 9 omissions, 0 notifications 100% passed
Rubocop
798 files inspected, no offenses detected