Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plexo: Update Network Token implementation #5169

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

javierpedrozaing
Copy link
Collaborator

Description

SER-1377

This commit update the previous implementation of NT in order to use network token instead if card

Unit test

Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test

32 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 9 omissions, 0 notifications 100% passed

Rubocop

798 files inspected, no offenses detected

@javierpedrozaing javierpedrozaing force-pushed the SER-1377-update_network_token_implementation branch 2 times, most recently from e3f72c2 to ccb8f5d Compare July 11, 2024 20:41
@javierpedrozaing javierpedrozaing marked this pull request as ready for review July 11, 2024 20:45
Copy link
Collaborator

@Heavyblade Heavyblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty much OK @javierpedrozaing, left some comments

lib/active_merchant/billing/gateways/plexo.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/plexo.rb Show resolved Hide resolved
Description
-------------------------
[SER-1377](https://spreedly.atlassian.net/browse/SER-1377)

This commit update the previous implementation of NT in order to use
network token instead if card

Unit test
-------------------------
Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test
-------------------------
Finished in 47.41717 seconds.

32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
100% passed

0.67 tests/s, 1.31 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected
@javierpedrozaing javierpedrozaing force-pushed the SER-1377-update_network_token_implementation branch from ccb8f5d to b62dab1 Compare July 15, 2024 16:39
@naashton naashton merged commit 957dd75 into master Jul 16, 2024
5 checks passed
@naashton naashton deleted the SER-1377-update_network_token_implementation branch July 16, 2024 18:58
javierpedrozaing added a commit that referenced this pull request Jul 25, 2024
Description
-------------------------
[SER-1377](https://spreedly.atlassian.net/browse/SER-1377)

This commit update the previous implementation of NT in order to use
network token instead if card

Unit test
-------------------------
Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test
-------------------------
Finished in 47.41717 seconds.

32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
100% passed

0.67 tests/s, 1.31 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
javierpedrozaing added a commit that referenced this pull request Jul 25, 2024
Description
-------------------------
[SER-1377](https://spreedly.atlassian.net/browse/SER-1377)

This commit update the previous implementation of NT in order to use
network token instead if card

Unit test
-------------------------
Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test
-------------------------
Finished in 47.41717 seconds.

32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
100% passed

0.67 tests/s, 1.31 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
bryansquadup pushed a commit to givehub/active_merchant that referenced this pull request Aug 21, 2024
Description
-------------------------
[SER-1377](https://spreedly.atlassian.net/browse/SER-1377)

This commit update the previous implementation of NT in order to use
network token instead if card

Unit test
-------------------------
Finished in 0.033159 seconds.

25 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

753.94 tests/s, 4131.61 assertions/s

Remote test
-------------------------
Finished in 47.41717 seconds.

32 tests, 62 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications
100% passed

0.67 tests/s, 1.31 assertions/s

Rubocop
-------------------------
798 files inspected, no offenses detected

Co-authored-by: Javier Pedroza <jpedroza@spreedly.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

3 participants