-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPs: Update NetworkTokenizationCreditCard flow #5178
Conversation
|
||
three_d_secure[:source] ||= card_brand(card_or_token) | ||
|
||
return unless (source = PAYMENT_DATA_SOURCE_MAPPING[three_d_secure[:source].to_sym]) | ||
|
||
xml.hps :SecureECommerce do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line needs to be the :Secure3D
now according to the docs in the ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or will there be a separate ticket for the 3dsecure updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks for pointing that out, I definitely missed that bullet point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though we have 3DS fields here it doesn't look like we support 3DS on our side for this gateway
b884fe9
to
7235692
Compare
@almalee24 Have you rerun the remote tests with the latest updates? |
Just saw this but yes I did |
xml.hps :WalletData do | ||
xml.hps :PaymentSource, PAYMENT_DATA_SOURCE_MAPPING[payment_method.source] | ||
xml.hps :Cryptogram, payment_method.payment_cryptogram | ||
xml.hps :ECI, payment_method.eci&.to_s&.sub!(/^0/, '') if payment_method.eci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use strip_leading_zero
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't even remember why but I'll update it do use strip_leading_zero
7235692
to
9b4d250
Compare
9b4d250
to
fa0e772
Compare
Update NetworkTokenizationCreditCArd flow to now be under WalletData. Remote 54 tests, 143 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.2963% passed Unit 61 tests, 295 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
fa0e772
to
0f2ae6f
Compare
Update NetworkTokenizationCreditCArd flow to now be under WalletData.
Remote
58 tests, 155 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.5517% passed
Unit
61 tests, 295 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed