Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SER-1386 add ExtraData and Source GSFs #5179

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Heavyblade
Copy link
Collaborator

Summary:

FlexCharge: quick fix on void call

SER-1386

Tests

Remote Test:

Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:

Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RuboCop:

798 files inspected, no offenses detected

@Heavyblade Heavyblade requested a review from naashton July 15, 2024 21:47
Copy link
Collaborator

@javierpedrozaing javierpedrozaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Summary:
------------------------------
FlexCharge: quick fix on void call

[SER-1386](https://spreedly.atlassian.net/browse/SER-1386)

Remote Test:
------------------------------
Finished in 70.477035 seconds.
19 tests, 54 assertions, 0 failures, 0 errors, 0 pendings,
1 omissions, 0 notifications
100% passed

Unit Tests:
------------------------------
Finished in 124.425603 seconds.
5959 tests, 79971 assertions, 0 failures, 0 errors, 0 pendings,
0 omissions, 0 notifications
100% passed

RuboCop:
------------------------------
798 files inspected, no offenses detected
@Heavyblade Heavyblade force-pushed the SER-1386_add_flexcharge_resource_gsf branch from 69be536 to 9c99078 Compare July 19, 2024 14:25
@Heavyblade Heavyblade merged commit 214d483 into master Jul 19, 2024
5 checks passed
@Heavyblade Heavyblade deleted the SER-1386_add_flexcharge_resource_gsf branch July 19, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants