-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvei: Base Gateway Layout #5182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javierpedrozaing, I did my review just focusing on the getSession call and left some comments for you
15f6e9a
to
2cbe0bc
Compare
2cbe0bc
to
c7a7a76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javierpedrozaing tons of nice work here, left you some comments and questions.
c7a7a76
to
c556185
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of work in here, so great job with this initial buildout. I had have a few design related concerns, specifically around the request and commit's.
I think, if we can do the following, we'll be in good shape:
- Consolidate the various
Response.new
to a helper method, this would be helpful for debugging in the future. - Perform the session token request/refresh in the
initialize
of the gateway. This will help us in 3DSGS implementation where the code stack may not hit those request/commit methods built in the AM adapter.
c556185
to
dbdaf38
Compare
Thanks Nick I did the updates to avoid use multi response on the commit method and request the session token on the init method. |
60d61ea
to
130dea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Make sure to add a changelog for this one 🚢
Description ------------------------- [SER-1351](https://spreedly.atlassian.net/browse/SER-1351) This commit add a the basic structure for the new Nuvei Gateway Unit test ------------------------- Finished in 0.010243 seconds. 3 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 292.88 tests/s, 878.65 assertions/s Remote test ------------------------- Finished in 20.996509 seconds. 10 tests, 21 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.48 tests/s, 1.00 assertions/s Rubocop ------------------------- 801 files inspected, no offenses detected
130dea8
to
14a790d
Compare
Description
SER-1351
This commit add a the basic structure for the new Nuvei Gateway
Unit test
Finished in 0.124334 seconds.
1 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
8.04 tests/s, 16.09 assertions/s
Remote test
Finished in 0.602895 seconds.
1 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
1.66 tests/s, 3.32 assertions/s
Rubocop
801 files inspected, no offenses detected