Nuvei: Base Gateway Layout #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavyblade
reviewed
Jul 18, 2024
There was a problem hiding this comment.
@javierpedrozaing, I did my review just focusing on the getSession call and left some comments for you
javierpedrozaing
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
from
15f6e9a
to
2cbe0bc
Compare
javierpedrozaing
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
from
2cbe0bc
to
c7a7a76
Compare
Heavyblade
reviewed
Jul 23, 2024
There was a problem hiding this comment.
@javierpedrozaing tons of nice work here, left you some comments and questions.
javierpedrozaing
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
from
c7a7a76
to
c556185
Compare
naashton
requested changes
Aug 9, 2024
There was a problem hiding this comment.
A lot of work in here, so great job with this initial buildout. I had have a few design related concerns, specifically around the request and commit's.
I think, if we can do the following, we'll be in good shape:
- Consolidate the various
Response.newto a helper method, this would be helpful for debugging in the future. - Perform the session token request/refresh in the
initializeof the gateway. This will help us in 3DSGS implementation where the code stack may not hit those request/commit methods built in the AM adapter.
javierpedrozaing
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
from
c556185
to
dbdaf38
Compare
Thanks Nick I did the updates to avoid use multi response on the commit method and request the session token on the init method. |
javierpedrozaing
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
3 times, most recently
from
60d61ea
to
130dea8
Compare
naashton
approved these changes
Aug 20, 2024
Description ------------------------- [SER-1351](https://spreedly.atlassian.net/browse/SER-1351) This commit add a the basic structure for the new Nuvei Gateway Unit test ------------------------- Finished in 0.010243 seconds. 3 tests, 9 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 292.88 tests/s, 878.65 assertions/s Remote test ------------------------- Finished in 20.996509 seconds. 10 tests, 21 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.48 tests/s, 1.00 assertions/s Rubocop ------------------------- 801 files inspected, no offenses detected
Heavyblade
force-pushed
the
SER-1352_nuvei_rest_base_gateway_layout
branch
from
130dea8
to
14a790d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SER-1351
This commit add a the basic structure for the new Nuvei Gateway
Unit test
Finished in 0.124334 seconds.
1 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
8.04 tests/s, 16.09 assertions/s
Remote test
Finished in 0.602895 seconds.
1 tests, 2 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
1.66 tests/s, 3.32 assertions/s
Rubocop
801 files inspected, no offenses detected