Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvei: Add basic Operation for Nuvei #5195

Closed

Conversation

javierpedrozaing
Copy link
Collaborator

@javierpedrozaing javierpedrozaing commented Jul 26, 2024

Description

SER-1349
SER-1350
SER-1348

This commit add the basic operation for Nuvei such as Purchase, refund, void and general credit

Unit test

Finished in 0.017629 seconds.

6 tests, 21 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

340.35 tests/s, 1191.22 assertions/s

Remote test

Finished in 30.626119 seconds.

19 tests, 50 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

0.62 tests/s, 1.63 assertions/s

Rubocop

801 files inspected, no offenses detected

@javierpedrozaing
Copy link
Collaborator Author

This PR has been rebased with the previous one to show all the passing tests and the complete progress so far. Eventually, this will be rebased and updated after deploying the initial PR.

@javierpedrozaing javierpedrozaing marked this pull request as ready for review July 30, 2024 19:19
@javierpedrozaing javierpedrozaing force-pushed the SER-1349_basic_operations_nuvey_gateway branch from d2dab59 to f23ed87 Compare August 2, 2024 20:20
Copy link
Collaborator

@gasb150 gasb150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very complete, I left a few comments for your consideration.

lib/active_merchant/billing/gateways/nuvei.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/nuvei.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/nuvei.rb Outdated Show resolved Hide resolved
@javierpedrozaing javierpedrozaing force-pushed the SER-1349_basic_operations_nuvey_gateway branch from f23ed87 to d902457 Compare August 6, 2024 15:57
@javierpedrozaing javierpedrozaing force-pushed the SER-1349_basic_operations_nuvey_gateway branch 2 times, most recently from e46b74a to c1836c8 Compare August 21, 2024 18:21
Description
-------------------------
[SER-1349](https://spreedly.atlassian.net/browse/SER-1349)
[SER-1350](https://spreedly.atlassian.net/browse/SER-1350)
[ser-1348](https://spreedly.atlassian.net/browse/SER-1348)

This commit add the basic operation for Nuvei such as
Purchase, refund, void, general credit and store

Unit test
-------------------------
Finished in 0.03932 seconds.

7 tests, 24 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

178.03 tests/s, 610.38 assertions/s

Remote test
-------------------------
Finished in 45.442297 seconds.

20 tests, 53 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

0.44 tests/s, 1.17 assertions/s

Rubocop
-------------------------
801 files inspected, no offenses detected
@javierpedrozaing javierpedrozaing force-pushed the SER-1349_basic_operations_nuvey_gateway branch from c1836c8 to 9efe1d6 Compare August 23, 2024 21:31
@javierpedrozaing
Copy link
Collaborator Author

Closed by PR 5230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants