Nuvei: Add store and stored credentials #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
from
8ec9503
to
21198c7
Compare
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
7 times, most recently
from
44bb639
to
a3ebb99
Compare
javierpedrozaing
changed the title
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
from
a3ebb99
to
d0d28ed
Compare
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
3 times, most recently
from
9e3f80d
to
8c40bda
Compare
naashton
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Implementation generally looks good, but I'm getting this error Ambiguous payment data. Both UPO and card data present. Only one should be provided! on the remote tests for SC.
24 tests, 69 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
87.5% passed
I pulled the creds from 1pass. Maybe something with the account config?
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
from
8c40bda
to
5f5bab9
Compare
naashton
approved these changes
Sep 11, 2024
Description ------------------------- This commit add store and stored credentials for Nuvei Gateway [SER-1357](https://spreedly.atlassian.net/browse/SER-1357) Unit test ------------------------- Finished in 0.034584 seconds. 9 tests, 30 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 260.24 tests/s, 867.45 assertions/s Remote test ------------------------- Finished in 59.543749 seconds. 23 tests, 69 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 0.39 tests/s, 1.16 assertions/s Rubocop ------------------------- 801 files inspected, no offenses detected
javierpedrozaing
force-pushed
the
ser-1357_nuvei_stored_credentials
branch
from
5f5bab9
to
b1dfcbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit add store and stored credentials for Nuvei Gateway
SER-1357
Unit test
Finished in 0.034584 seconds.
9 tests, 30 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
260.24 tests/s, 867.45 assertions/s
Remote test
Finished in 59.543749 seconds.
23 tests, 69 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
0.39 tests/s, 1.16 assertions/s
Rubocop
801 files inspected, no offenses detected