Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adyen: Update split refund method #5218

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

yunnydang
Copy link
Contributor

@yunnydang yunnydang commented Aug 15, 2024

This change updates the add_split method to be more flexible when building and sending the split object to Adyen.

Local:
5988 tests, 80175 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Unit:
123 tests, 649 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote:
145 tests, 467 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
91.7241% passed

@yunnydang yunnydang requested a review from a team August 15, 2024 22:57
@yunnydang yunnydang self-assigned this Aug 15, 2024
@yunnydang yunnydang force-pushed the adyen_fix_split_payment_refund branch from 136daa0 to e9b37bf Compare August 19, 2024 20:52
lib/active_merchant/billing/gateways/adyen.rb Outdated Show resolved Hide resolved
lib/active_merchant/billing/gateways/adyen.rb Outdated Show resolved Hide resolved
test/remote/gateways/remote_adyen_test.rb Outdated Show resolved Hide resolved
@yunnydang yunnydang force-pushed the adyen_fix_split_payment_refund branch from e9b37bf to 582f1d4 Compare August 22, 2024 19:40
Copy link
Contributor

@jcreiff jcreiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@yunnydang yunnydang force-pushed the adyen_fix_split_payment_refund branch from 582f1d4 to 780a77d Compare August 27, 2024 17:09
@yunnydang yunnydang merged commit 780a77d into master Aug 27, 2024
5 checks passed
@yunnydang yunnydang deleted the adyen_fix_split_payment_refund branch August 27, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants